-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG (string dtype): convert dictionary input to materialized string array in ArrowStringArray constructor #59479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mroeschke
merged 1 commit into
pandas-dev:main
from
jorisvandenbossche:string-dtype-arrow-disallow-dict-storage
Aug 12, 2024
Merged
BUG (string dtype): convert dictionary input to materialized string array in ArrowStringArray constructor #59479
mroeschke
merged 1 commit into
pandas-dev:main
from
jorisvandenbossche:string-dtype-arrow-disallow-dict-storage
Aug 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rray in ArrowStringArray constructor
mroeschke
approved these changes
Aug 12, 2024
Thanks @jorisvandenbossche |
WillAyd
pushed a commit
that referenced
this pull request
Aug 13, 2024
…rray in ArrowStringArray constructor (#59479)
shreyas-dev
pushed a commit
to shreyas-dev/pandas
that referenced
this pull request
Aug 13, 2024
…rray in ArrowStringArray constructor (pandas-dev#59479)
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 14, 2024
…rray in ArrowStringArray constructor (pandas-dev#59479)
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 15, 2024
…rray in ArrowStringArray constructor (pandas-dev#59479)
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 15, 2024
…rray in ArrowStringArray constructor (pandas-dev#59479)
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 15, 2024
…rray in ArrowStringArray constructor (pandas-dev#59479)
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 21, 2024
…rray in ArrowStringArray constructor (pandas-dev#59479)
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 22, 2024
…rray in ArrowStringArray constructor (pandas-dev#59479)
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 22, 2024
…rray in ArrowStringArray constructor (pandas-dev#59479)
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 22, 2024
…rray in ArrowStringArray constructor (pandas-dev#59479)
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 27, 2024
…rray in ArrowStringArray constructor (pandas-dev#59479)
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Sep 20, 2024
…rray in ArrowStringArray constructor (pandas-dev#59479)
jorisvandenbossche
added a commit
to WillAyd/pandas
that referenced
this pull request
Oct 2, 2024
…rray in ArrowStringArray constructor (pandas-dev#59479)
jorisvandenbossche
added a commit
to WillAyd/pandas
that referenced
this pull request
Oct 2, 2024
…rray in ArrowStringArray constructor (pandas-dev#59479)
jorisvandenbossche
added a commit
to WillAyd/pandas
that referenced
this pull request
Oct 3, 2024
…rray in ArrowStringArray constructor (pandas-dev#59479)
jorisvandenbossche
added a commit
to WillAyd/pandas
that referenced
this pull request
Oct 7, 2024
…rray in ArrowStringArray constructor (pandas-dev#59479)
jorisvandenbossche
added a commit
that referenced
this pull request
Oct 9, 2024
…rray in ArrowStringArray constructor (#59479)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#54074 allowed to pass dictionary encoded string data in the
ArrowStringArray
constructor, because such values can be passed when reading partitioned datasets (it was fixing #53951).However, when you actually have a column with string dtype but backed by a dictionary encoded pyarrow array, our StringArray implemention is not set up for that, so once you call some string specific functionality, you can run into errors. Example:
Maybe we could at some point properly support storing dict encoded string values under the hood. But until then, I think it is better to materialize the dictionary encoded input to a plain pyarrow string array, which is what this PR is doing.
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.