-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
TST: Add test for feather
I/O with historical out-of-bounds datetime
values
#60209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: Add test for feather
I/O with historical out-of-bounds datetime
values
#60209
Conversation
8c0c6ac
to
1320034
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR
1320034
to
5cd403a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed that we have check_round_trip
. We can simplify the test with that.
5cd403a
to
7985a21
Compare
TST: feather I/O with historical out-of-bounds datetime values TST: feather I/O with historical out-of-bounds datetime values TST: feather I/O with historical out-of-bounds datetime values
7985a21
to
14dc724
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR adds a unit test to
pandas/tests/io/test_feather.py
to verify that out-of-bounds datetime values (historical dates outside of standard datetime64[ns] range) are correctly handled when saved to and loaded from Feather files. Addresses GH #47832.