Skip to content

ENH: json_normalize accepts JSON with str and bytes input #61056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

ENH: json_normalize accepts JSON with str and bytes input #61056

wants to merge 5 commits into from

Conversation

arthurlw
Copy link
Contributor

@arthurlw arthurlw commented Mar 4, 2025 •
edited
Loading

mroeschke
mroeschke requested changes Mar 5, 2025
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR but I would be -1 on this feature. We recently deprecated accepting JSON-like strings in read_json so this would go against that API consistency.

Additionally the data preprocessing logic here appears straightforward enough to be done by the caller

@arthurlw
Copy link
Contributor Author

arthurlw commented Mar 5, 2025 •
edited
Loading

Thanks for the review! I was unaware of the deprecation, but I understand the concern about API consistency. Will be closing this for now

@arthurlw arthurlw closed this Mar 5, 2025
@mroeschke mroeschke mentioned this pull request Mar 5, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ENH: json_normalize should work with JSON
2 participants
@arthurlw @mroeschke