BUG: Added deprecation warning to Timestamp constructor #61149
Conversation
pandas/tests/indexing/test_loc.py
Outdated
| @pytest.mark.filterwarnings("ignore:indexing past lexsort depth") | ||
| @pytest.mark.filterwarnings( | ||
| "ignore:indexing past lexsort depth", | ||
| "ignore:Passing an empty string to Timestamp", |
There was a problem hiding this comment.
Instead of ignoring in each of these tests, can you test the warning. See
https://pandas.pydata.org/pandas-docs/dev/development/contributing_codebase.html#testing-a-warning
There was a problem hiding this comment.
@jhendricks487 - you still need to modify the other tests where this warning occurs with tm.assert_produces_warning. Any warning that occurs outside of such a block will result in the test failing.
rhshadrach
added
Deprecate
…dricks/pandas into add-warning-timestamp-blank-string
|
@rhshadrach should be good now, but let me know if you have any suggested improvements! |
There was a problem hiding this comment.
When using tm.assert_produces_warning, you can also pass None to indicate that no warning should be raised. So a lot of times in the testing code you'll see something like
klass = FutureWarning if [condition] else None
tm.assert_produces_warning(klass, match=msg):
This avoids having to branch in the test itself.
| if ts_input == "": | ||
| warnings.warn( | ||
| "Passing an empty string to Timestamp is deprecated and will raise " | ||
| "a ValueError in a future version.", |
There was a problem hiding this comment.
Can you add Use `pd.NaT` directly instead.
| with tm.assert_produces_warning(FutureWarning, match=msg): | ||
| exp_index = index.insert(len(index), key) |
There was a problem hiding this comment.
This looks problematic - the warning message will say not to pass "" to Timestamp but the user is doing no such thing. It looks like we'll have to change the internals here to avoid triggering the warning message. This applies to all the warnings in this PR where you aren't explicitly passing "" to Timestamp.
If you want any assistance in how to change, let me know and I'm happy to take a look.
Part of #11953
Added deprecation warning to Timestamp constructor when
ts_input = "".This addition was motivated by this comment: #11953 (comment)
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.