Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: date comparison fails when series is all pd.NaT values #61188 #61200

Closed
wants to merge 9 commits into from
1 change: 1 addition & 0 deletions doc/source/whatsnew/v3.0.0.rst
Original file line number Diff line number Diff line change
Expand Up @@ -641,6 +641,7 @@ Categorical

Datetimelike
^^^^^^^^^^^^
- Bug in :attr:`Series.dt.date` where Series with all NaT values would raise an error when compared to a datetime.date (:issue:`61188`)
- Bug in :attr:`is_year_start` where a DateTimeIndex constructed via a date_range with frequency 'MS' wouldn't have the correct year or quarter start attributes (:issue:`57377`)
- Bug in :class:`DataFrame` raising ``ValueError`` when ``dtype`` is ``timedelta64`` and ``data`` is a list containing ``None`` (:issue:`60064`)
- Bug in :class:`Timestamp` constructor failing to raise when ``tz=None`` is explicitly specified in conjunction with timezone-aware ``tzinfo`` or data (:issue:`48688`)
Expand Down
4 changes: 3 additions & 1 deletion pandas/core/indexes/accessors.py
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,9 @@ def _delegate_property_get(self, name: str):
else:
index = self._parent.index
# return the result as a Series
return Series(result, index=index, name=self.name).__finalize__(self._parent)
return Series(
result, index=index, name=self.name, dtype=result.dtype
).__finalize__(self._parent)

def _delegate_property_set(self, name: str, value, *args, **kwargs) -> NoReturn:
raise ValueError(
Expand Down
22 changes: 22 additions & 0 deletions pandas/tests/series/indexing/test_datetime.py
Original file line number Diff line number Diff line change
Expand Up @@ -491,3 +491,25 @@ def test_compare_datetime_with_all_none():
result = ser > ser2
expected = Series([False, False])
tm.assert_series_equal(result, expected)


def test_dt_date_dtype_all_nat_is_object():
# Ensure .dt.date on all-NaT Series returns object dtype and not datetime64
# GH#61188
s = Series([pd.NaT, pd.NaT])
s = pd.to_datetime(s)
result = s.dt.date

expected = Series([pd.NaT, pd.NaT], dtype=object)

tm.assert_series_equal(result, expected)


def test_dt_date_all_nat_le_date():
# All-NaT Series should not raise error when compared to a datetime.date
# GH#61188
s = Series([pd.NaT, pd.NaT])
s = pd.to_datetime(s)
result = s.dt.date <= datetime.now().date()
expected = Series([False, False])
tm.assert_series_equal(result, expected)