BUG: Fix #61222: Keep index name when resampling with pyarrow dtype #61229
+13
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthiboust
force-pushed
the
fix-issue-61222
branch
2 times, most recently
from
066ec11 to
f79ef8a
Compare
mthiboust
force-pushed
the
fix-issue-61222
branch
from
f79ef8a to
b9062c3
Compare
mroeschke
reviewed
Apr 4, 2025
| @@ -169,7 +169,7 @@ Groupby/resample/rolling | |||
|
|
|||
| Reshaping | |||
| ^^^^^^^^^ | |||
| - | |||
| - :meth:`DataFrame.resample` was not keeping the index name when the index had :class:`pyarrow` datetime dtype (:issue:`61222`) | |||
There was a problem hiding this comment.
Can you move this to v3.0.0.rst?
mroeschke
reviewed
Apr 4, 2025
Comment on lines
+520
to
+522
| obj = self.obj | ||
| result.index = result.index.astype(self._timegrouper._arrow_dtype) | ||
| result.index.name = getattr(obj.index, "name", None) |
There was a problem hiding this comment.
Suggested change
| obj = self.obj | |
| result.index = result.index.astype(self._timegrouper._arrow_dtype) | |
| result.index.name = getattr(obj.index, "name", None) | |
| result.index = result.index.astype(self._timegrouper._arrow_dtype) | |
| result.index.name = self.obj.index.name |
mroeschke
reviewed
Apr 4, 2025
| expected = Series(np.arange(5, dtype=np.float64), index=idx) | ||
| expected.index.name = "index_name" | ||
| result = expected.resample("1D").mean() | ||
| assert result.index.name == expected.index.name |
There was a problem hiding this comment.
Suggested change
| assert result.index.name == expected.index.name | |
| tm.assert_series_equal(result, expected) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.