-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Pyarrow timestamp support for map() function #61236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arthurlw
wants to merge
22
commits into
pandas-dev:main
Choose a base branch
from
arthurlw:pyarrow-timestamp-support-for-map
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+50
−11
Open
Changes from 6 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
0ce5571
implemented pyarrow timestamp support
arthurlw 469e28d
added test
arthurlw 1dbf5d1
precommit
arthurlw 1cf2de8
whatsnew
arthurlw 52dc7fb
added import condition for pyarrow in test
arthurlw 66215a9
precommit
arthurlw 4445ecd
moved logic from algorithms.py to ArrowExtensionArray.map
arthurlw 49e130c
Updated condition
arthurlw 79c1fe2
updated according to reviewer suggestions
arthurlw 91e6401
Merge branch 'main' into pyarrow-timestamp-support-for-map
arthurlw 19d2870
reverted array.py logic
arthurlw 88c180c
change cast to dtype="datetime64[ns]"
arthurlw a421e66
precommit
arthurlw 04dda0d
updated test and map condition
arthurlw 02ae824
updated test
arthurlw 73c4039
wrap with pd.series
arthurlw b918323
casted typing
arthurlw f3545bf
updated test logic
arthurlw 4526bb1
updated testing logic
arthurlw 52cd37f
precommit
arthurlw 25e57c3
improved code readability
arthurlw c9f47ff
return with proper typing
arthurlw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -604,3 +604,14 @@ def test_map_kwargs(): | |||||
result = Series([2, 4, 5]).map(lambda x, y: x + y, y=2) | ||||||
expected = Series([4, 6, 7]) | ||||||
tm.assert_series_equal(result, expected) | ||||||
|
||||||
|
||||||
def test_map_arrow_timestamp_dict(): | ||||||
# GH 61231 | ||||||
pytest.importorskip("pyarrow", minversion="10.0.1") | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
ser = Series(date_range("2023-01-01", periods=3)).astype("timestamp[ns][pyarrow]") | ||||||
mapper = {ts: i for i, ts in enumerate(ser)} | ||||||
result = ser.map(mapper) | ||||||
expected = Series([0, 1, 2], dtype="int64") | ||||||
tm.assert_series_equal(result, expected) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the wrong place to fix this. This should be fixed in
ArrowExtensionArray.map