-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Add Pandas Cookbook to Book Recommendations #61271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks @WillAyd |
@WillAyd @mroeschke @pandas-dev/pandas-core, great to have the book added (and published), but would it makes sense to revert this commit? It's still the last one, and it increases the repo size by 1.3Mb for the book cover. We can optimize it like the other book covers, and leave it in around 10Kb with reasonable quality. Also, the image url in the html has the wrong extension (gif), the correct one is jpeg, so the home page shows the image broken right now. It'll surely make things a bit tricky for people who cloned the code since this was merged, but personally I think it's worth. |
Ah sorry about the image size - yes can replace with an optimized one.
Hmm so do I need to save the file as a gif in the git repo? The other two books have that extension |
The extension is irrelevant, it's just the mismatch the problem. gif allows to have smaller color palettes, which can help reduce the image size, that's why the others are gif. The main question here is if we just fix this, and we let the 1.3Mb stay in our git history, or if we hard undo this in the commit history, avoiding the 1.3Mb, but creating a bit of trouble to few uses because rewriting git history. If people are not ok with this, then better to leave the image as it is, and just fix the extension in the html so it renders correctly. |
I would be fine with a hard undo since its the HEAD of main. I don't foresee that causing too much trouble |
For people who cloned or pulled the reverted commit git will error, and not sure if just require the |
Alternative: https://dalibornasevic.com/posts/2-permanently-remove-files-and-folders-from-a-git-repository Not sure how intrusive that would be as opposed to just removing the last commit. |
I would also support hard undoing the last commit |
Done. I'll open a new PR with the changes here |
The link here is a special link used to track sales of the Pandas Cookbook through the pandas website. NumFOCUS and Packt (the publisher) have agreed that the latter will donate part of the proceeds through this link directly back to NumFOCUS