-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Fix #61072: inconsistent fullmatch results with regex alternation #61343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Pedro-Santos04
wants to merge
7
commits into
pandas-dev:main
Choose a base branch
from
Pedro-Santos04:bug#61072
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c2b768b
Fix #61072: inconsistent fullmatch results with regex alternation
Pedro-Santos04 9b917a2
Fix #61072: Fix regex grouping for PyArrow fullmatch tests
Pedro-Santos04 e666916
Update boolean dtype representation and improve regex handling in Str…
Pedro-Santos04 f5d3b9b
Changed return type from bollean to bool
Pedro-Santos04 8477264
Updated errors
Pedro-Santos04 75de765
Updated errors
Pedro-Santos04 dddebff
Enhance documentation for StringMethods.fullmatch with examples and u…
Pedro-Santos04 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
import pytest | ||
|
||
from pandas import Series | ||
|
||
|
||
@pytest.mark.parametrize("dtype", [str]) | ||
def test_string_array(dtype): | ||
test_series = Series(["asdf", "as"], dtype=dtype) | ||
regex = r"((as)|(as))" | ||
regex2 = r"(as)|(as)" | ||
assert list(test_series.str.fullmatch(regex)) == [False, True] | ||
assert list(test_series.str.fullmatch(regex2)) == [False, True] | ||
|
||
|
||
@pytest.mark.parametrize( | ||
"data, pattern, expected", | ||
[ | ||
(["cat", "duck", "dove"], r"d.+", [False, True, True]), | ||
], | ||
) | ||
def test_string_match(data, pattern, expected): | ||
ser = Series(data) | ||
assert list(ser.str.fullmatch(pattern)) == expected | ||
|
||
|
||
@pytest.mark.parametrize("dtype", [str]) | ||
@pytest.mark.parametrize( | ||
"pattern, expected", | ||
[ | ||
(r"(foo)|((as)(df)?)", [True, True, True]), | ||
("foo|as", [False, True, True]), | ||
], | ||
) | ||
def test_string_alternation_patterns(dtype, pattern, expected): | ||
ser = Series(["asdf", "foo", "as"], dtype=dtype) | ||
assert list(ser.str.fullmatch(pattern)) == expected |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to be an improper solution to me. Can you explain why the current code path fails?