Skip to content

Wheels for win_arm64 #61463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions .github/workflows/wheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ jobs:
# Note: M1 images on Github Actions start from macOS 14
- [macos-14, macosx_arm64]
- [windows-2022, win_amd64]
- [windows-11-arm, win_arm64]
# TODO: support PyPy?
python: [["cp310", "3.10"], ["cp311", "3.11"], ["cp312", "3.12"], ["cp313", "3.13"], ["cp313t", "3.13"]]
include:
Expand All @@ -112,6 +113,12 @@ jobs:
- buildplat: [ubuntu-22.04, pyodide_wasm32]
python: ["cp312", "3.12"]
cibw_build_frontend: 'build'
exclude:
- buildplat: [windows-11-arm, win_arm64]
python: ["cp310", "3.10"]
# BackendUnavailable: Cannot import 'mesonpy'
- buildplat: [windows-11-arm, win_arm64]
python: ["cp313t", "3.13"]

env:
IS_PUSH: ${{ github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v') }}
Expand All @@ -122,6 +129,12 @@ jobs:
with:
fetch-depth: 0

- name: Set up MSVC environment for ARM64
if: matrix.buildplat[1] == 'win_arm64'
uses: ilammy/msvc-dev-cmd@v1
with:
arch: arm64

# TODO: Build wheels from sdist again
# There's some sort of weird race condition?
# within Github that makes the sdist be missing files
Expand Down Expand Up @@ -159,9 +172,12 @@ jobs:
env:
CIBW_BUILD: ${{ matrix.python[0] }}-${{ matrix.buildplat[1] }}
CIBW_BUILD_FRONTEND: ${{ matrix.cibw_build_frontend || 'pip' }}
CIBW_PLATFORM: ${{ matrix.buildplat[1] == 'pyodide_wasm32' && 'pyodide' || 'auto' }}
CIBW_PLATFORM: ${{ (matrix.buildplat[1] == 'pyodide_wasm32' && 'pyodide') || (matrix.buildplat[1] == 'win_arm64' && 'windows') || 'auto' }}
CIBW_ARCHS: ${{ matrix.buildplat[1] == 'win_arm64' && 'ARM64' || 'auto' }}
CIBW_BEFORE_BUILD_WINDOWS: 'python -m pip install delvewheel'

- name: Set up Python
- name: Set up Python for validation/upload (non-ARM64 Windows & other OS)
if: matrix.buildplat[1] != 'win_arm64'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So wheel is not installable in this environment on win_arm64?

Copy link
Author

@khmyznikov khmyznikov May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mroeschke micromamba is not available on win_arm64. That's why I'm installing wheel in next steps

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, can you add a comment here to that effect?

uses: mamba-org/setup-micromamba@v2
with:
environment-name: wheel-env
Expand All @@ -176,7 +192,11 @@ jobs:

- name: Validate wheel RECORD
shell: bash -el {0}
run: for whl in $(ls wheelhouse); do wheel unpack wheelhouse/$whl -d /tmp; done
run: |
if [[ "${{ matrix.buildplat[1] }}" == "win_arm64" ]]; then
python -m pip install wheel
fi
Comment on lines +196 to +198
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this a dedicated step instead?

for whl in $(ls wheelhouse); do wheel unpack wheelhouse/$whl -d /tmp; done

- uses: actions/upload-artifact@v4
with:
Expand Down
Loading