Skip to content

BUG: Index.delete doesnt preserve name and other attrs #7302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/source/v0.14.1.txt
Original file line number Diff line number Diff line change
Expand Up @@ -70,3 +70,4 @@ Bug Fixes
- Bug in ``DataFrame`` and ``Series`` bar and barh plot raises ``TypeError`` when ``bottom``
and ``left`` keyword is specified (:issue:`7226`)
- BUG in ``DataFrame.hist`` raises ``TypeError`` when it contains non numeric column (:issue:`7277`)
- BUG in ``Index.delete`` does not preserve ``name`` and ``freq`` attributes (:issue:`7302`)
4 changes: 3 additions & 1 deletion pandas/core/index.py
Original file line number Diff line number Diff line change
Expand Up @@ -1770,7 +1770,9 @@ def delete(self, loc):
-------
new_index : Index
"""
return np.delete(self, loc)
return self._simple_new(np.delete(self, loc), self.name,
freq=getattr(self, 'freq', None),
tz=getattr(self, 'tz', None))

def insert(self, loc, item):
"""
Expand Down
17 changes: 17 additions & 0 deletions pandas/tests/test_index.py
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,23 @@ def test_insert(self):
self.assertTrue(Index(['a']).equals(
null_index.insert(0, 'a')))

def test_delete(self):
idx = Index(['a', 'b', 'c', 'd'], name='idx')

expected = Index(['b', 'c', 'd'], name='idx')
result = idx.delete(0)
self.assertTrue(result.equals(expected))
self.assertEqual(result.name, expected.name)

expected = Index(['a', 'b', 'c'], name='idx')
result = idx.delete(-1)
self.assertTrue(result.equals(expected))
self.assertEqual(result.name, expected.name)

with tm.assertRaises((IndexError, ValueError)):
# either depeidnig on numpy version
result = idx.delete(5)

def test_identical(self):

# index
Expand Down
11 changes: 0 additions & 11 deletions pandas/tseries/index.py
Original file line number Diff line number Diff line change
Expand Up @@ -1608,17 +1608,6 @@ def insert(self, loc, item):
return self.asobject.insert(loc, item)
raise TypeError("cannot insert DatetimeIndex with incompatible label")

def delete(self, loc):
"""
Make new DatetimeIndex with passed location deleted

Returns
-------
new_index : DatetimeIndex
"""
arr = np.delete(self.values, loc)
return DatetimeIndex(arr, tz=self.tz)

def _view_like(self, ndarray):
result = ndarray.view(type(self))
result.offset = self.offset
Expand Down
31 changes: 29 additions & 2 deletions pandas/tseries/tests/test_timeseries.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
import os
import operator

from distutils.version import LooseVersion

import nose

import numpy as np
Expand Down Expand Up @@ -2094,6 +2092,35 @@ def test_insert(self):
result = idx.insert(3, datetime(2000, 4, 30))
self.assertEqual(result.freqstr, 'M')

def test_delete(self):
idx = date_range(start='2000-01-01', periods=4, freq='M', name='idx')

expected = date_range(start='2000-02-01', periods=3, freq='M', name='idx')
result = idx.delete(0)
self.assertTrue(result.equals(expected))
self.assertEqual(result.name, expected.name)
self.assertEqual(result.freqstr, 'M')

expected = date_range(start='2000-01-01', periods=3, freq='M', name='idx')
result = idx.delete(-1)
self.assertTrue(result.equals(expected))
self.assertEqual(result.name, expected.name)
self.assertEqual(result.freqstr, 'M')

with tm.assertRaises((IndexError, ValueError)):
# either depeidnig on numpy version
result = idx.delete(5)

idx = date_range(start='2000-01-01', periods=4,
freq='M', name='idx', tz='US/Pacific')

expected = date_range(start='2000-02-01', periods=3,
freq='M', name='idx', tz='US/Pacific')
result = idx.delete(0)
self.assertTrue(result.equals(expected))
self.assertEqual(result.name, expected.name)
self.assertEqual(result.freqstr, 'M')

def test_map_bug_1677(self):
index = DatetimeIndex(['2012-04-25 09:30:00.393000'])
f = index.asof
Expand Down