Skip to content

MAINT: get rid of some compiler warnings #9395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2015
Merged

MAINT: get rid of some compiler warnings #9395

merged 1 commit into from
Jul 2, 2015

Conversation

larsmans
Copy link
Contributor

@larsmans larsmans commented Feb 2, 2015

  • uninitialized pointer
  • unused variables
  • unused function
  • ISO C prototypes
  • cimport *
  • useless cast before snprintf

@TomAugspurger TomAugspurger added the Build Library building on various platforms label Feb 4, 2015
@TomAugspurger TomAugspurger added this to the 0.16.0 milestone Feb 4, 2015
@TomAugspurger
Copy link
Contributor

Thanks for looking into this.

What compiler are you using? I may have a chance to try it out with clang.

@larsmans
Copy link
Contributor Author

larsmans commented Feb 5, 2015

GCC 4.7.

@jreback jreback modified the milestones: 0.16.0, Next Major Release Mar 3, 2015
@jreback
Copy link
Contributor

jreback commented May 9, 2015

can you rebase this?

@larsmans
Copy link
Contributor Author

larsmans commented May 9, 2015

@jreback done.

@jreback
Copy link
Contributor

jreback commented May 9, 2015

can you quantify I guess how many warnings this removed? (as obviously still lots)

@jreback jreback modified the milestones: 0.17.0, Next Major Release May 9, 2015
@larsmans
Copy link
Contributor Author

larsmans commented May 9, 2015

I don't know, four, five? The code has moved on since I wrote this patch and I have no idea how many new warnings were introduced.

@jreback
Copy link
Contributor

jreback commented Jun 26, 2015

this looks ok, but to be sure, can you rebase and push again? ping when green.

@larsmans
MAINT: get rid of some compiler warnings
edb572c 
* uninitialized pointer
* unused variables
* unused function
* ISO C prototypes
* cimport *
* useless cast before snprintf
@larsmans
Copy link
Contributor Author

larsmans commented Jul 2, 2015

Green!

jreback added a commit that referenced this pull request Jul 2, 2015
@jreback
Merge pull request #9395 from larsmans/cleanup
9ed13a1 
MAINT: get rid of some compiler warnings
@jreback jreback merged commit 9ed13a1 into pandas-dev:master Jul 2, 2015
@jreback
Copy link
Contributor

jreback commented Jul 2, 2015

thanks!

@larsmans larsmans deleted the cleanup branch July 3, 2015 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Build Library building on various platforms
Projects
None yet
Milestone
0.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@larsmans @TomAugspurger @jreback