Skip to content

JSDoc highlighting for optional parameters #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexlafroscia opened this issue Jul 26, 2016 · 2 comments
Closed

JSDoc highlighting for optional parameters #574

alexlafroscia opened this issue Jul 26, 2016 · 2 comments
Assignees
Labels

Comments

@alexlafroscia
Copy link

I've noticed that vim-javascript does an excellent job with most JSDoc highlighting, but gets confused on optional parameters.

Here's a screenshot showing how both "normal" and "optional" parameters are handled.

screen shot 2016-07-26 at 1 29 54 pm

It would be great if it showed up the same color, and even better if the each part was highlighted separately to make the default value stand out, if provided.

@TamsynUlthara
Copy link
Contributor

Just pushed up #660 which fixes the issue.

FWIW, I usually write all my Vim regexes prefixed with \v just so I don't go crazy trying to track down bugs like that. ;-)

@alexlafroscia
Copy link
Author

Awesome, thanks @tomxtobin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants