Skip to content

Fix JSDoc highlighting for optional parameters #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2016
Merged

Fix JSDoc highlighting for optional parameters #660

merged 1 commit into from
Oct 10, 2016

Conversation

TamsynUlthara
Copy link
Contributor

Fixes #574.

Copy link
Collaborator

@bounceme bounceme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the closing bracket need to be escaped also?

@bounceme
Copy link
Collaborator

bounceme commented Oct 6, 2016

\|\[.\{-}] to this \|\[.\{-}\]

@TamsynUlthara
Copy link
Contributor Author

Does the closing bracket need to be escaped also?

Not with the default regex magic, no. (I find the magic rules so confusing that I always prefix my Vim regexes with \v, so they're fairly close to PCREs or POSIX EREs.)

@bounceme
Copy link
Collaborator

bounceme commented Oct 6, 2016

oh, in the help it explains the behavior that some internal functions have:


                                *E769*
    When the ']' is not there Vim will not give an error message but
    assume no collection is used.  Useful to search for '['.  However, you
    do get E769 for internal searching.  And be aware that in a
    `:substitute` command the whole command becomes the pattern.  E.g.
    ":s/[/x/" searches for "[/x" and replaces it with nothing.  It does
    not search for "[" and replaces it with "x"!

@amadeus amadeus merged commit 25e9865 into pangloss:master Oct 10, 2016
@bounceme
Copy link
Collaborator

Oh, that was into master haha. try not to do that

@amadeus
Copy link
Collaborator

amadeus commented Oct 10, 2016

Oh whoops, it was from mobile (so I couldn't see the target), and since it wasn't brought up earlier, I just assumed it was correct.

@bounceme
Copy link
Collaborator

I missed it too. the dev to master push should cover it up

@TamsynUlthara TamsynUlthara mentioned this pull request Oct 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants