indentation refactoring

[bounceme]

No description provided.

[bounceme]

more testing needed for this, everything is working(except for a few string problems,and generally worse performance, which i hope to fix)

[bounceme]

this is largely finished, if your reading this can you please test? performance suffers within large blocks of code but the simplification makes this a fair trade in my opinion

[markrian]

I'll test this today, and report here with any regressions or bugs.

[markrian]

Testing has so far revealed only one thing I'd definitely call a bug, and a couple of other things which are perhaps a matter of personal preference. The former I can only reproduce on a fairly large file, and I'm having trouble producing a minimal test case. In fact, it almost seems like the size is to blame, since changing the file at all seems to resolve the bug. That file is proprietary, so I can't share it, sadly. Once I've managed to make a minimal test case, I'll put it here.

I'll describe the other personal preference "bugs" later, too, when I have some time.

[markrian]

Bizarrely, it seems that this bug I mentioned only happens when the file I'm working with is 1035 lines or more long. If I remove any line in the file, even blank lines, before, inside or after (?!) the incorrectly indented code, it then indents the whole file correctly.

[bounceme]

these are caused by the timeout for the search pair function, default is 300 ms. maybe it should be configurable if this gets merged
unfortunately this method requires the very slow search pair function for almost every line indented. the default python and clojure indent scripts work the same but instead of using a timeout they limit the number of lines : https://github.com/neovim/neovim/blob/master/runtime/indent/python.vim#L58-L59
. sadly, there is a incredibly fast way, but it can break in some cases due to the differences between c and js strings

[bounceme]

i have a few ideas for improving the speed issue, 300 ms is too much(though it would only take that long in a very big block scope)

[bounceme]

@markrian there have been improvements to this, is this working any better for you?

[markrian]

I'll take a look tomorrow. Sounds good!

[amadeus]

So this sounds like it might be an improvement over develop then. I'll try and test it out soon.

[bounceme]

I think this is about done, if you see any regressions let me know. also i am glad to hear any suggestions on what i've tried here

[bounceme]

I'll merge later today or tomorrow if its alright with @amadeus & @markrian

[markrian]

I'm afraid I've found another indenting bug. Trying to produce minimal test case.

[markrian]

It seems to be another idempotency issue. The follow correctly indented code stays intact after one gg=G:

'use strict';

function foo() {
}

but a second call results in this:

'use strict';

    function foo() {
    }

and subsequent calls indent the function further and further.

[markrian]

Just found another one. Do/while loops mess up indentation of the line immediately following them:

function foo() {
    do {
        anything();
    } while (false)

         anything();
    anything();
}

[bounceme]

i think the first issue is fixed but the do while syntax makes it very unlikely that can be solved unless there is a do block syntax element added, which may or may not be possible

[bounceme]

actually,i'll try and port this
https://github.com/mooz/js2-mode/blob/master/js2-old-indent.el#L253

[bounceme]

been on vacation this past week, hopefully someone was testing this as I'd like to finish and merge it tomorrow

[amadeus]

Overall, things have been pretty good, however I have found a couple weird instances, mostly working within JSX files, not sure if they are related to JSX, or if it's something deeper with JS.

I'll see if I can isolate the problems over the next couple days.

[amadeus]

However, at this point, it may be worth merging this in and then working to fix the rest of the issues over time? Also getting it into develop will inevitably get more eyes on it and therefore more issues may be found to get fixed.

[bounceme]

Sounds fine, i'll merge after a few finishing touches