#267 Modify get_attribute_info_map to take slice instead of vec #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tead of vec. Signed-off-by: Ivo Zeba <[email protected]>
ivozeba
force-pushed
the
get_attribute_info_map-AttributeType-slice
branch
from
f2ee601 to
be6dd3f
Compare
ivozeba
changed the title
hug-dev
previously approved these changes
May 12, 2025
|
Yep, it looks good, but please |
Signed-off-by: Ivo Zeba <[email protected]>
hug-dev
approved these changes
May 13, 2025
wiktor-k
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the argument from vec to slice as highlighted in #267 and updated the only test case that used get_attribute_info_map.