Skip to content

Remove Node 12 and 15 support #1535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
SebC99 opened this issue Aug 28, 2022 · 3 comments · Fixed by #1603
Closed
3 tasks done

Remove Node 12 and 15 support #1535

SebC99 opened this issue Aug 28, 2022 · 3 comments · Fixed by #1603
Labels
type:feature New feature or improvement of existing feature

Comments

@SebC99
Copy link
Contributor

SebC99 commented Aug 28, 2022

New Feature / Enhancement Checklist

Current Limitation

Current build settings allow for node.js from version 8. But as far as I can see, it can only be used via parse-server which only supports nodejs from version 12.

Feature / Enhancement Description

Could we change node support for Parse SDK JS as well? It would allow using ES7 features as object destructuring without the need for a polyfill.

Example Use Case

As an example, these lines seems to be the slowest (by far) in Parse.Object getter, which is called a lot in any code. Replacing these lines with a simple const data = {...serverData}; is more than 80% faster according to jsbench.

@parse-github-assistant
Copy link

parse-github-assistant bot commented Aug 28, 2022

Thanks for opening this issue!

  • ❌ Please edit your post and use the provided template when creating a new issue. This helps everyone to understand your post better and asks for essential information to quicker review the issue.

@mtrezza mtrezza changed the title Question about node version Bump node version Aug 29, 2022
@mtrezza mtrezza added the type:feature New feature or improvement of existing feature label Aug 29, 2022
@mtrezza
Copy link
Member

mtrezza commented Aug 29, 2022

I'd suggest:

  1. Create a PR which sets the min node version for the JS SDK to >=12 and refactors the bottlenecks you mentioned
  2. Publish a minor release in Parse Server with the new JS SDK

Later, when we are bumping the node version to >=14 in Parse Server, we can also so that in the JS SDK. The bump to Node 14 in Parse Server will happen in 4 months with Parse Sever 6.x, at the end of the year.

@mtrezza mtrezza changed the title Bump node version Bump node version to >= 12 Aug 29, 2022
@mtrezza mtrezza changed the title Bump node version to >= 12 Bump node engine version to >= 12 Aug 29, 2022
@mtrezza mtrezza pinned this issue Aug 29, 2022
@mtrezza mtrezza changed the title Bump node engine version to >= 12 Drop Node 12 support Nov 6, 2022
@mtrezza mtrezza changed the title Drop Node 12 support Remove Node 12 and 15 support Nov 6, 2022
@mtrezza
Copy link
Member

mtrezza commented Nov 6, 2022

A PR for this should cover:

  • Remove support for Node 12 and 15
  • Add engines.node to package.json, not sure why this is currently missing
  • Update Node compatibility table in README
  • Update Node badge table in README

@mtrezza mtrezza unpinned this issue Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature or improvement of existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants