Skip to content

fix: Remove support for Node <14 #1603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Nov 8, 2022

New Pull Request Checklist

Issue Description

Currently Parse JS SDK supports NodeJS versions that have reached EOL.

Related issue: #1535
Closes #1535

Approach

Removes Node 12 support, changes build target to Node 14

TODOs before merging

  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Nov 8, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@mtrezza mtrezza changed the title fix: Change minimum node version fix: Remove support for Node <14 Nov 10, 2022
@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Base: 99.93% // Head: 99.93% // No change to project coverage 👍

Coverage data is based on head (d0e3aaf) compared to base (a52c4c6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #1603   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files          61       61           
  Lines        5966     5966           
  Branches     1366     1366           
=======================================
  Hits         5962     5962           
  Misses          4        4           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza added the state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message label Nov 10, 2022
@mtrezza mtrezza merged commit bc04b4b into parse-community:alpha Nov 10, 2022
parseplatformorg pushed a commit that referenced this pull request Nov 10, 2022
# [4.0.0-alpha.1](3.5.1-alpha.2...4.0.0-alpha.1) (2022-11-10)

### Bug Fixes

* Remove support for Node <14 ([#1603](#1603)) ([bc04b4b](bc04b4b))

### BREAKING CHANGES

* This release removes support for Node versions <14 ([bc04b4b](bc04b4b))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.0.0-alpha.1

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Nov 10, 2022
@parse-github-assistant
Copy link

The label state:released-alpha cannot be used in combination with state:breaking.

@parse-github-assistant parse-github-assistant bot removed the state:released-alpha Released as alpha version label Nov 10, 2022
@dblythy dblythy deleted the remove-node-12 branch November 10, 2022 13:54
mtrezza pushed a commit to mtrezza/Parse-SDK-JS that referenced this pull request Jan 22, 2023
BREAKING CHANGE: This release removes support for Node versions <14
mtrezza pushed a commit to mtrezza/Parse-SDK-JS that referenced this pull request Jan 22, 2023
* Remove support for Node <14 ([parse-community#1603](parse-community#1603)) ([bc04b4b](parse-community@bc04b4b))

* This release removes support for Node versions <14 ([bc04b4b](bc04b4b))
parseplatformorg pushed a commit that referenced this pull request Jan 23, 2023
# [4.0.0-beta.1](3.5.1...4.0.0-beta.1) (2023-01-23)

### Bug Fixes

* `Parse.Query.subscribe()` does not return a rejected promise on error in Cloud Code Triggers `beforeConnect` or `beforeSubscribe` ([#1490](#1490)) ([96d7174](96d7174))
* Remove support for Node <14 ([#1603](#1603)) ([bc04b4b](bc04b4b))

### Features

* Add Node 16 and 18 support ([#1598](#1598)) ([2c79a31](2c79a31))
* Add node 19 support ([8ed0fab](8ed0fab))
* Add Node 19 support ([#1643](#1643)) ([dfb5196](dfb5196))

### Performance Improvements

* Avoid CORS preflight request by removing upload listener when not used ([#1610](#1610)) ([6125419](6125419))

### BREAKING CHANGES

* Calling `Parse.Query.subscribe()` will now return a rejected promise if an error is thrown in Cloud Code Triggers `beforeConnect` or `beforeSubscribe`; in previous releases a resolved promise was returned, even if subscribing failed and it was necessary to create an `error.on` listener to handle these errors (#1490) ([96d7174](96d7174))
* This release removes support for Node versions <14 ([bc04b4b](bc04b4b))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jan 23, 2023
parseplatformorg pushed a commit that referenced this pull request Jan 23, 2023
# [4.0.0](3.5.1...4.0.0) (2023-01-23)

### Bug Fixes

* `Parse.Query.subscribe()` does not return a rejected promise on error in Cloud Code Triggers `beforeConnect` or `beforeSubscribe` ([#1490](#1490)) ([96d7174](96d7174))
* Remove support for Node <14 ([#1603](#1603)) ([bc04b4b](bc04b4b))

### Features

* Add Node 16 and 18 support ([#1598](#1598)) ([2c79a31](2c79a31))
* Add node 19 support ([8ed0fab](8ed0fab))
* Add Node 19 support ([#1643](#1643)) ([dfb5196](dfb5196))

### Performance Improvements

* Avoid CORS preflight request by removing upload listener when not used ([#1610](#1610)) ([6125419](6125419))

### BREAKING CHANGES

* Calling `Parse.Query.subscribe()` will now return a rejected promise if an error is thrown in Cloud Code Triggers `beforeConnect` or `beforeSubscribe`; in previous releases a resolved promise was returned, even if subscribing failed and it was necessary to create an `error.on` listener to handle these errors (#1490) ([96d7174](96d7174))
* This release removes support for Node versions <14 ([bc04b4b](bc04b4b))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message state:released Released as stable version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Node 12 and 15 support
3 participants