Skip to content

fix: fix locfile #1542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 22 commits into from
Closed

fix: fix locfile #1542

wants to merge 22 commits into from

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Sep 10, 2022

New Pull Request Checklist

Issue Description

Regenerates lockfile

Related issue: #1515

Approach

re-run npm i

TODOs before merging

n/a

dblythy added 10 commits August 19, 2020 14:11
Hi all,

Not sure if my formatting is perfect but closes parse-community#1176 (removes pre. SDK 2.0 success functions), and adds documentation for LiveQuery triggers.

Also, for me, when I google "Parse Javascript SDK", it takes me to v1.11.0. Is there any way we can add "This SDK is outdated" or some other warning to point users to the latest SDK?

Thank you!
@parse-github-assistant
Copy link

parse-github-assistant bot commented Sep 10, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@dblythy dblythy changed the title Fix locfile fix: fix locfile Sep 10, 2022
@dblythy dblythy closed this Sep 10, 2022
@dblythy dblythy deleted the fix-locfile branch September 10, 2022 02:59
@dblythy dblythy reopened this Sep 10, 2022
@codecov
Copy link

codecov bot commented Sep 10, 2022

Codecov Report

Base: 99.94% // Head: 99.94% // No change to project coverage 👍

Coverage data is based on head (f6c535f) compared to base (ca7d448).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #1542   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          61       61           
  Lines        5955     5955           
  Branches     1360     1360           
=======================================
  Hits         5952     5952           
  Misses          3        3           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dblythy
Copy link
Member Author

dblythy commented Sep 10, 2022

Note: this PR is just proof that parse-community/parse-server#8159 fixes the lockfile issue

@mtrezza mtrezza marked this pull request as draft September 11, 2022 21:31
@mtrezza
Copy link
Member

mtrezza commented Sep 11, 2022

I've converted this to DRAFT to make sure it doesn't get merged by mistake.

@dblythy dblythy closed this Sep 12, 2022
@dblythy dblythy reopened this Sep 12, 2022
@dblythy
Copy link
Member Author

dblythy commented Sep 12, 2022

Tests passing @mtrezza

@mtrezza
Copy link
Member

mtrezza commented Sep 18, 2022

Closed at this was just for CI testing purpose to fix #1515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants