Skip to content

fix: SDK builds incorrectly since release 3.5.0 causing various bugs #1600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 7, 2022
Merged

fix: SDK builds incorrectly since release 3.5.0 causing various bugs #1600

merged 2 commits into from
Nov 7, 2022

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Nov 7, 2022 •
edited by mtrezza
Loading

New Pull Request Checklist

Issue Description

This took me quiet some time to unpack. There have been some bugs reported relating to basic functionality, such as #1596, #1593, #1592, and this community forum issue.

After replicating myself, I narrowed it down to #1553. The compiled code babel is generating before and after that PR were completely different, with one using this in places where it would be undefined (in strict mode). After painstakingly trying to figure out which sub-dependancy update caused the bug, I gave up and updated all dependancies using ncu. Thankfully the bug was fixed, so next I went through each single change to try isolate which was necessary.

Related issues: #1599, #1596, #1593, #1592, #1601
Closes #1599
Closes #1596
Closes #1593
Closes #1592
Closes #1601
Closes #1614
Closes #1618

Approach

This PR adds puppeteer and launches a mock browser to test basic SDK functionality. In the first commit, you can see the tests failing due to the babel bug. After the dependancy update, you can see those tests pass as the problematic dependancy is updated. I have also updated some babel syntax (I was going through the entire configuration to try work out if something was depreciated).

TODOs before merging

  • Add tests
  • Add entry to changelog

@parse-github-assistant
Copy link

parse-github-assistant bot commented Nov 7, 2022 •
edited
Loading

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@dblythy
Copy link
Member Author

dblythy commented Nov 7, 2022

Shoutout to @aarondill for their efforts too!

@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Base: 99.93% // Head: 99.93% // No change to project coverage 👍

Coverage data is based on head (eec60b0) compared to base (a52c4c6).
Patch has no changes to coverable lines.

❗ Current head eec60b0 differs from pull request most recent head bf7f89c. Consider uploading reports for the commit bf7f89c to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##            alpha    #1600   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files          61       61           
  Lines        5966     5966           
  Branches     1366     1366           
=======================================
  Hits         5962     5962           
  Misses          4        4

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dblythy dblythy requested a review from a team November 7, 2022 11:47
@dblythy
Copy link
Member Author

dblythy commented Nov 7, 2022

Tests passing (woo!). I have added very minimal tests to the browser dist tester for now - can add more if you would like

@mtrezza
Copy link
Member

mtrezza commented Nov 7, 2022

Amazing work! 🙌

mtrezza
mtrezza approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza changed the title fix: SDK building incorrectly fix: SDK builds incorrectly causing various bugs Nov 7, 2022
@mtrezza mtrezza changed the title fix: SDK builds incorrectly causing various bugs fix: SDK builds incorrectly causing various bugs since release 3.5.0 Nov 7, 2022
@mtrezza mtrezza changed the title fix: SDK builds incorrectly causing various bugs since release 3.5.0 fix: SDK builds incorrectly since release 3.5.0 causing various bugs Nov 7, 2022
@mtrezza mtrezza merged commit f15154f into parse-community:alpha Nov 7, 2022
@dblythy dblythy deleted the test-build branch November 7, 2022 13:25
parseplatformorg pushed a commit that referenced this pull request Nov 7, 2022
@semantic-release-bot
chore(release): 3.5.1-alpha.2 [skip ci]
7fe54a2 
## [3.5.1-alpha.2](3.5.1-alpha.1...3.5.1-alpha.2) (2022-11-07)

### Bug Fixes

* SDK builds incorrectly since release 3.5.0 causing various bugs ([#1600](#1600)) ([f15154f](f15154f))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 3.5.1-alpha.2

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Nov 7, 2022
This was referenced Nov 7, 2022
Closed
Closed
Closed
Closed
Closed
This was referenced Nov 18, 2022
Closed
Closed
@mtrezza mtrezza mentioned this pull request Nov 19, 2022
Closed
3 tasks
parseplatformorg pushed a commit that referenced this pull request Nov 26, 2022
@semantic-release-bot
chore(release): 3.5.1-beta.2 [skip ci]
28aaad0 
## [3.5.1-beta.2](3.5.1-beta.1...3.5.1-beta.2) (2022-11-26)

### Bug Fixes

* SDK builds incorrectly since release 3.5.0 causing various bugs ([#1600](#1600)) ([f15154f](f15154f))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 3.5.1-beta.2

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Nov 26, 2022
parseplatformorg pushed a commit that referenced this pull request Nov 26, 2022
@semantic-release-bot
chore(release): 3.5.1 [skip ci]
0d8df83 
## [3.5.1](3.5.0...3.5.1) (2022-11-26)

### Bug Fixes

* File upload fails when uploading base64 data ([#1578](#1578)) ([03ee3ff](03ee3ff))
* React Native build does not maintain arrow functions and causes error with AsyncStorage ([#1587](#1587)) ([8aeaa4f](8aeaa4f))
* SDK builds incorrectly since release 3.5.0 causing various bugs ([#1600](#1600)) ([f15154f](f15154f))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 3.5.1

@parseplatformorg parseplatformorg added the state:released Released as stable version label Nov 26, 2022
@dplewis dplewis mentioned this pull request Jan 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Milestone
No milestone
3 participants
@dblythy @mtrezza @parseplatformorg