Skip to content

Bumps to alpha version of node-apn #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Bumps to alpha version of node-apn #105

wants to merge 2 commits into from

Conversation

flovilmart
Copy link
Contributor

  • Bumps engine
  • Bumps CI
  • Adds instructions for using custom adapter

@codecov
Copy link

codecov bot commented Dec 30, 2017 •
edited
Loading

Codecov Report

Merging #105 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #105   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines         258    258           
=====================================
  Hits          258    258
Impacted Files Coverage Δ
src/ParsePushAdapter.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7f9bc4...6506d28. Read the comment docs.

funkenstrahlen
funkenstrahlen previously approved these changes Dec 30, 2017
View reviewed changes
Copy link
Contributor

@funkenstrahlen funkenstrahlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for me. Have not tested this yet on a real server. I did test apn 3.0.0-alpha1 though successfully.

@flovilmart
Copy link
Contributor Author

Did you test the setup instructions? I already published the package, can you let us know how it goes? I’ll deploy it after new year

@funkenstrahlen
Copy link
Contributor

funkenstrahlen commented Dec 30, 2017 •
edited
Loading

@flovilmart The setup instructions are only required if I want to use a custom version of the push adapter, correct?

I will check the installation instructions.

@flovilmart
Copy link
Contributor Author

If you want to test this adapter at the 3.0.0-alpha1 version with your current parse server setup for example

@funkenstrahlen
Copy link
Contributor

funkenstrahlen commented Dec 30, 2017 •
edited
Loading

I checked the installation instructions. Works fine.

Because I am running my test backend on heroku I had to add this to my package.json: "@parse/push-adapter": "3.0.0-alpha1", instead of using npm directly to install the package.

@funkenstrahlen
Copy link
Contributor

funkenstrahlen commented Dec 30, 2017 •
edited
Loading

I do run 3.0.0-alpha1 on my test backend now. Works fine so far. However the ping bug that should be solved with apn 3.0.0-alpha1 never occurred on the test backend anyway because I have very few installations on this backend that can receive push notifications. So I can not really confirm if it is gone now.

@flovilmart
Bumps to alpha version of node-apn
618abdb 
- Bumps engine
- Bumps CI
- Adds instructions for using custom adapter
@flovilmart
⚡ 3.0.0
6506d28 
- Release 3.0.0
- Bumps node-gcm to latest version
@flovilmart flovilmart closed this May 22, 2019
@flovilmart flovilmart deleted the apn-alpha-1 branch May 22, 2019 13:25
@parseplatformorg parseplatformorg mentioned this pull request Oct 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@funkenstrahlen funkenstrahlen funkenstrahlen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flovilmart @funkenstrahlen