-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Expose DatabaseAdapter to simplify application tests #1121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
drew-gross
merged 10 commits into
parse-community:master
from
supersolid:steven.database.testutils
Apr 8, 2016
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
308ab55
Move helper.clearData to DatabaseAdapter. Expose DatabaseAdapter in i…
steven-supersolid 2730b52
Merge remote-tracking branch 'upstream/master' into steven.database.t…
steven-supersolid c7d8f89
fix indentation
steven-supersolid 58c874a
Merge remote-tracking branch 'upstream/master' into steven.database.t…
steven-supersolid d984f94
Merge remote-tracking branch 'upstream/master' into steven.database.t…
steven-supersolid 94c4f01
Merge remote-tracking branch 'upstream/master' into steven.database.t…
steven-supersolid 9ae423b
Export DatabaseAdapter in index.js
steven-supersolid fb95114
Rename clearData to destroyAllDataPermanently. Only export destroyAll…
steven-supersolid 9f4ba7e
Expose wrapped TestUtils from index.js. TestUtils exposed select func…
steven-supersolid 7651e4c
Merge remote-tracking branch 'upstream/master' into steven.database.t…
steven-supersolid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
import { destroyAllDataPermanently } from './DatabaseAdapter'; | ||
|
||
let unsupported = function() { | ||
throw 'Only supported in test environment'; | ||
}; | ||
|
||
let _destroyAllDataPermanently; | ||
if (process.env.TESTING) { | ||
_destroyAllDataPermanently = destroyAllDataPermanently; | ||
} else { | ||
_destroyAllDataPermanently = unsupported; | ||
} | ||
|
||
export default { | ||
destroyAllDataPermanently: _destroyAllDataPermanently}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wrapped this a little differently, can change if there is any advantage to the previously suggested way of doing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's ok too