Fix #1591 #1626
Closed
Fix #1591 #1626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead of reverting, could we create a test case and I'll do the fix tonight? |
Current coverage is 91.41%@@ master #1626 diff @@
==========================================
Files 87 87
Lines 6154 6156 +2
Methods 1082 1076 -6
Messages 0 0
Branches 1278 1279 +1
==========================================
- Hits 5682 5627 -55
- Misses 472 529 +57
Partials 0 0
|
|
It's tough to create a test case as we need to test the behaviour of Parse.com. Maybe I can add a test case on the schema collection directly or something. |
|
Like make sure after a Push sent, the _PushStatus don't exists on the Schema? |
|
Yeah kinda. I'll have a test case for you soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the change that caused #1591. We'll need to come up with some strategy for handling system classes that are new in Parse Server. In the meantime, doing this means we aren't blocked from releasing 2.2.8