Non trivial before save pointer clobber #2406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically if beforeSave makes any changes to the object it is trying to save, the fetched pointer fields on the client gets clobbered to only pointer.
Earlier we were returning all fields even if any changes happened in beforeSave. This causes the fetched pointer fields on the client to get clobbered to only pointers. This fix returns only the changed fields thus avoiding pointer clobber.
…s the user correctly. Also it is consistent with the hosted parse that user.username not returned from PUT request.
ghost
added
the
Current coverage is 91.84% (diff: 100%)@@ master #2406 diff @@
==========================================
Files 95 95
Lines 10708 10707 -1
Methods 1309 1310 +1
Messages 0 0
Branches 1741 1740 -1
==========================================
- Hits 9835 9834 -1
Misses 873 873
Partials 0 0
|
|
The travis failures https://travis-ci.org/ParsePlatform/parse-server/jobs/147683600 when I run it against my repo seems to be passing. So going to re-trigger the ci. |
|
So every time the timout is happening in different cases. |
|
@flovilmart Hey, everytime I trigger test, it seems to be timing out on one of the node/mongo version. Any idea how to get this thro? |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the beforeSave makes changes to the object being saved, the fetched pointer fields on the client gets clobbered to only pointers.
It is related to #1238
But the beforeSave also makes changes to the object being saved.