Cleanup and modernize S3Adapter to ES6 syntax. #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Creates an S3 session. | ||
| // Providing AWS access and secret keys is mandatory | ||
| // Region and bucket will use sane defaults if omitted | ||
| constructor(accessKey, secretKey, options = {}) { |
There was a problem hiding this comment.
With ES6 we can use destructuring assignment in arguments
constructor(accessKey, secretKey, {
region = DEFAULT_S3_REGION,
bucket = DEFAULT_S3_BUCKET,
...options
} = {}) {
this._region = region;
//etc.
}
There was a problem hiding this comment.
Yes! Completely forgot about the awesomeness of that feature!
|
Some minor nits, feel free to merge anyone after rebasing. |
nlutsenko
force-pushed
the
nlutsenko.files.s3
branch
from
d1b473c to
1358eb8
Compare
nlutsenko
force-pushed
the
nlutsenko.files.s3
branch
from
1358eb8 to
07c9c1d
Compare
|
@nlutsenko updated the pull request. |
nlutsenko
added a commit
that referenced
this pull request
Feb 10, 2016
Cleanup and modernize S3Adapter to ES6 syntax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also allows usage of S3Adapter instead of new GridStoreAdapter, since both conform to the same interface.