-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Throw when query is encoded incorrectly #410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Marco129 can you add tests to emphasize on the fix?, also given the API from expressjs here: http://expressjs.com/en/4x/api.html#req.query the req.query object should be set. |
Looks like I wrongly encoded the However, current Parse API do decode the
Should we maintain this compatibility? |
Yeah the = signs are not supposed to be encoded unless they are part of a value to make the difference between the parameters and the value they hold. There is a risk with the double encoding as you may unencode a 'wrong' = sign and then render the params unusable. If we handle the = sign encoding ( |
1ac5013
to
312d065
Compare
@Marco129 updated the pull request. |
312d065
to
06b8157
Compare
@Marco129 updated the pull request. |
After several test, I found that Parse API also buggy in handling the encoded As encoding |
@Marco129 updated the pull request. |
Throw when query is encoded incorrectly
👍 |
Fix for #101 #211
Since the original
req.query
did not decode correctly, curl with --data-urlencode will fail.