Skip to content

Update test case polygons so some should fail when lat / long is used… #4608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

JacobJT
Copy link

@JacobJT JacobJT commented Mar 6, 2018

… improperly

@JacobJT
Copy link
Author

JacobJT commented Mar 6, 2018

This PR updates some of the Polygons used in the test spec, which should trigger tests to fail. Polygons were almost all squares that were mirrored over an x=y line, so it did not expose issues where the lat/long values either were or were not swapped appropriately.

@@ -129,7 +129,7 @@ describe('Parse.Polygon testing', () => {
});

it('polygonContain query', (done) => {
const points1 = [[0,0],[0,1],[1,1],[1,0]];
Copy link
Author

@JacobJT JacobJT Mar 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the most important change. If the coordinates of either the polygon or the coordinate we are seeing if is contained within the polygon are reversed from what we intend, the check will fail. To be frank, many of the other changes may be completely moot, as they seem to be just validating data that exists and doesn't criss / cross. In all likelihood, everything but this line change could be scrapped to highlight the same results

@JacobJT
Copy link
Author

JacobJT commented Mar 7, 2018

The appropriate test was moved to #4609

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant