Skip to content

Live query defaults reference ParseServer instead of LiverQuery server. #4613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

acinader
Copy link
Contributor

@acinader acinader commented Mar 8, 2018

nit wording fix for live query defaults

@flovilmart
Copy link
Contributor

@acinader, the help message is generated from the definition file.

@codecov
Copy link

codecov bot commented Mar 8, 2018

Codecov Report

Merging #4613 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4613   +/-   ##
=======================================
  Coverage   92.64%   92.64%           
=======================================
  Files         119      119           
  Lines        8560     8560           
=======================================
  Hits         7930     7930           
  Misses        630      630
Impacted Files Coverage Δ
src/Routers/PushRouter.js 92.85% <0%> (-3.58%) ⬇️
src/RestWrite.js 93.6% <0%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0674df...b12d944. Read the comment docs.

@acinader acinader force-pushed the livequery-default-port-wording branch from 3ca6faa to fa241d4 Compare March 8, 2018 18:35
@acinader
Copy link
Contributor Author

acinader commented Mar 8, 2018

@flovilmart like that? And there's even a nice helpful message at the top and everything.

@flovilmart
Copy link
Contributor

Yep, but you need to regenreate the config with node resources/buildConfigDefinitions.js We should probably put that here:

https://github.com/parse-community/parse-server/blob/master/src/Options/Definitions.js#L4

which is generated here:

https://github.com/parse-community/parse-server/blob/master/resources/buildConfigDefinitions.js#L228

@acinader
Copy link
Contributor Author

acinader commented Mar 8, 2018

regenerated. i think the comment is good as is.....

@flovilmart
Copy link
Contributor

Thanks!

@flovilmart flovilmart merged commit d19ac07 into parse-community:master Mar 8, 2018
@acinader acinader deleted the livequery-default-port-wording branch March 8, 2018 22:32
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
…r. (parse-community#4613)

* fix workding for live query defaults help

* generate the definition file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants