-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Update PostgresStorageAdapter.js #6275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Improving use of the `await.async` notation in relation to `pg-promise`, and in general.
Correcting some results.
Codecov Report
@@ Coverage Diff @@
## master #6275 +/- ##
==========================================
+ Coverage 93.81% 93.82% +<.01%
==========================================
Files 169 169
Lines 11564 11564
==========================================
+ Hits 10849 10850 +1
+ Misses 715 714 -1
Continue to review full report at Codecov.
|
@vitaly-t Thanks for the PR, it looks good to me. Is there a reason why this is an improvement? I always use async / await like this. |
@dplewis The initial idea was to improve methods such as Methods such as those, resolve with |
Oh I see, you are right they shouldn't return. The adapter should conform to the StorageAdapter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* Update PostgresStorageAdapter.js Improving use of the `await.async` notation in relation to `pg-promise`, and in general. * Update PostgresStorageAdapter.js * Update PostgresStorageAdapter.js Correcting some results. * Update PostgresStorageAdapter.js
Improving use of the
await/async
notation in relation topg-promise
, and in general.