-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
GraphQL: Optimize on Relation (and Prettier stuff) #7044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7044 +/- ##
==========================================
+ Coverage 93.84% 93.88% +0.04%
==========================================
Files 169 169
Lines 12438 12438
==========================================
+ Hits 11673 11678 +5
+ Misses 765 760 -5
Continue to review full report at Codecov.
|
@Moumouls I can't find the changes in the PR. You only pushed the prettier :) |
@davimacedo change is |
@@ -10,10 +10,10 @@ const needToGetAllKeys = (fields, keys, parseClasses) => | |||
? keys.split(',').some(keyName => { | |||
const key = keyName.split('.'); | |||
if (fields[key[0]]) { | |||
if (fields[key[0]].type === 'Relation') return false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Herer @davimacedo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry. My bad. LGTM!
Strange, it seems that some files have not been processed by prettier.
Main fix is here