-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
fix: custom field name collides with internal field name #7258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: alpha
Are you sure you want to change the base?
fix: custom field name collides with internal field name #7258
Conversation
Thanks for the test. I can do a fix for this since I introduced it. I also have a few more fields that will be reserved. |
|
@dplewis is there any update in relation to this issue? or any planned development on this? |
@pausenabre I assume this is a larger effort, see the discussion in the related issue. The issue is still open. |
New Pull Request Checklist
Issue Description
This PR doesn't fix the issue, but adds a failing test which demonstrates the problem.
The test
length
to1
beforeSave
hookunset
s the invalid fieldlength
Expected result:
The
beforeSave
hook succeeds tounset
the invalid field.Actual result:
An error
105
–Invalid field name for update: length
is thrown before thebeforeSave
hook is executed, and nounset
operation is done.Related issue: #7130
Approach
The test was added in the
CloudCode.spec.js
file.