-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
ci: Fix docker image pushing to Docker Hub #7548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening this pull request!
|
Codecov Report
@@ Coverage Diff @@
## master #7548 +/- ##
==========================================
- Coverage 93.97% 93.93% -0.05%
==========================================
Files 181 181
Lines 13279 13279
==========================================
- Hits 12479 12473 -6
- Misses 800 806 +6
Continue to review full report at Codecov.
|
If you want to add docker images for missing versions on docker hub (4.5.2 - 4.10.3), cherry pick this commit, place it in the respective release branch, and in |
Corrected a spelling error that's been around for awhile:
|
It looks like the multi-platform images worked! https://hub.docker.com/r/parseplatform/parse-server/tags?page=1&ordering=last_updated |
🎉 This change has been released in version 5.0.0-beta.1 |
🎉 This change has been released in version 5.0.0 |
New Pull Request Checklist
Issue Description
Related issue: #7547
Approach
Use GitHub Actions to push to Docker hub during merges of PRs and releases. Merges to the master branch push the latest image to
latest
on Docker Hub and releases push the latest release with the same tag name. You can see the tags this creates using my research repo: https://hub.docker.com/repository/docker/netreconlab/parse-dashboardThis builds images for multiple architectures as oppose to just Intel. Builds for all of same architectures as it’s dependency image, node:lts-alpine except for
linux/ppc64le
andlinux/s390x
as those both currently fail.A side-effect is it creates another tag on docker-hub called
master
, which I guess could be useful if something else is pushed afterlatest
TODOs before merging