Skip to content

refactor: code style fixes with prettier and lint #8208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2022
Merged

refactor: code style fixes with prettier and lint #8208

merged 1 commit into from
Oct 3, 2022

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Oct 3, 2022 •
edited
Loading

New Pull Request Checklist

Issue Description

When creating a PR and running prettier, other changes are added.

Related issue: n/a

Approach

Runs prettier & lint-fix

TODOs before merging

  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Oct 3, 2022 •
edited
Loading

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Related issue: #123 in the PR description, so I can recognize it.

@dblythy dblythy requested a review from a team October 3, 2022 02:25
@codecov
Copy link

codecov bot commented Oct 3, 2022 •
edited
Loading

Codecov Report

Base: 93.96% // Head: 93.96% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (d5b41a5) compared to base (63d51fa).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##            alpha    #8208      +/-   ##
==========================================
- Coverage   93.96%   93.96%   -0.01%     
==========================================
  Files         182      182              
  Lines       13744    13744              
==========================================
- Hits        12915    12914       -1     
- Misses        829      830       +1
Impacted Files Coverage Δ
src/Config.js 88.92% <0.00%> (ø)
src/Adapters/Files/GridFSBucketAdapter.js 79.50% <0.00%> (-0.82%) ⬇️
src/RestWrite.js 94.63% <0.00%> (-0.15%) ⬇️
src/ParseServerRESTController.js 98.48% <0.00%> (+1.51%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

mtrezza
mtrezza approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza changed the title refactor: run prettier && lint-fix refactor: code style fixes with prettier and lint Oct 3, 2022
@mtrezza mtrezza merged commit 2a82d19 into parse-community:alpha Oct 3, 2022
@dblythy dblythy deleted the run-prettier branch October 3, 2022 11:56
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.3.0-alpha.28

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Oct 11, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.4.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Oct 29, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.4.0-alpha.1

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.4.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Nov 19, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.4.0

@parseplatformorg parseplatformorg added the state:released-5.x.x Released as LTS version label Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:released Released as stable version state:released-5.x.x Released as LTS version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dblythy @parseplatformorg @mtrezza