-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
refactor: Upgrade pg-promise to 11.3.0 and pg-monitor to 2.0.0 #8453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening this pull request! |
I suspect something is up with the node cache or something else as these pass locally. I used the following commands to update pg-promise and pg-monitor: npm i -E [email protected] [email protected] I used |
I managed to find an older version of node for the lock file. This is ready for review. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## alpha #8453 +/- ##
==========================================
- Coverage 94.31% 93.99% -0.32%
==========================================
Files 183 183
Lines 14459 14459
==========================================
- Hits 13637 13591 -46
- Misses 822 868 +46
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
🎉 This change has been released in version 6.1.0-alpha.3 |
🎉 This change has been released in version 6.1.0-beta.2 |
🎉 This change has been released in version 6.1.0 |
Pull Request
Issue
pg-promise and pg-monitor are not up-to-date and the node-postgres driver pg-promise depends on is out-of-date. Continuation on #8365 #8364
Closes: #8454
Approach
Update pg-promise to 11.3.0 and pg-monitor to 2.0.0 (this version has a minimum dependency on pg-promise 11.0.0).
pg-promise 11.0.0 removed
poolSize
in favor ofmax
more info here). Since the parse-serverPostgresConfigParser
already supports bothpoolSize
andmax
this PR setspoolSize
tomax
so it's not a breaking change on the parse-server. If both are set,max
always takes precedence.Tasks