Skip to content

refactor: Upgrade pg-promise to 11.3.0 and pg-monitor to 2.0.0 #8453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 5, 2023

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Mar 2, 2023

Pull Request

Issue

pg-promise and pg-monitor are not up-to-date and the node-postgres driver pg-promise depends on is out-of-date. Continuation on #8365 #8364

Closes: #8454

Approach

Update pg-promise to 11.3.0 and pg-monitor to 2.0.0 (this version has a minimum dependency on pg-promise 11.0.0).

pg-promise 11.0.0 removed poolSize in favor of max more info here). Since the parse-server PostgresConfigParser already supports both poolSize and max this PR sets poolSize to max so it's not a breaking change on the parse-server. If both are set, max always takes precedence.

Tasks

@parse-github-assistant
Copy link

parse-github-assistant bot commented Mar 2, 2023

Thanks for opening this pull request!

@cbaker6
Copy link
Contributor Author

cbaker6 commented Mar 2, 2023

I suspect something is up with the node cache or something else as these pass locally. I used the following commands to update pg-promise and pg-monitor:

I used node 19.3.0. Not sure why changes to node_modules/mock-files-adapter and node_modules/mock-email-adapter were made, maybe the lock file was created with an older version of node?

@cbaker6
Copy link
Contributor Author

cbaker6 commented Mar 3, 2023

I managed to find an older version of node for the lock file.

This is ready for review.

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.32 ⚠️

Comparison is base (22d2446) 94.31% compared to head (d285ddb) 93.99%.

❗ Current head d285ddb differs from pull request most recent head d76aca9. Consider uploading reports for the commit d76aca9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #8453      +/-   ##
==========================================
- Coverage   94.31%   93.99%   -0.32%     
==========================================
  Files         183      183              
  Lines       14459    14459              
==========================================
- Hits        13637    13591      -46     
- Misses        822      868      +46     
Impacted Files Coverage Δ
.../Adapters/Storage/Postgres/PostgresConfigParser.js 100.00% <100.00%> (ø)
src/Adapters/Cache/RedisCacheAdapter.js 17.39% <0.00%> (-73.92%) ⬇️
src/LiveQuery/ParseCloudCodePublisher.js 84.21% <0.00%> (-15.79%) ⬇️
src/Routers/AggregateRouter.js 90.00% <0.00%> (-8.00%) ⬇️
src/Adapters/Files/GridFSBucketAdapter.js 93.47% <0.00%> (-0.73%) ⬇️
src/ParseServer.js 92.20% <0.00%> (-0.44%) ⬇️
src/LiveQuery/ParseLiveQueryServer.js 95.77% <0.00%> (-0.22%) ⬇️
src/Adapters/Storage/Mongo/MongoTransform.js 88.37% <0.00%> (-0.16%) ⬇️
src/RestWrite.js 94.61% <0.00%> (-0.15%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza merged commit 87cab09 into parse-community:alpha Mar 5, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.1.0-alpha.3

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Mar 6, 2023
@cbaker6 cbaker6 deleted the updatePostgres branch March 6, 2023 04:49
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.1.0-beta.2

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label May 1, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.1.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pg-promise and node-postgres are out-of-date
3 participants