-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
feat: Add TypeScript definitions #9693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚀 Thanks for opening this pull request! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #9693 +/- ##
==========================================
- Coverage 93.16% 93.01% -0.15%
==========================================
Files 187 187
Lines 15068 15081 +13
Branches 0 174 +174
==========================================
- Hits 14038 14028 -10
- Misses 1030 1041 +11
- Partials 0 12 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@dplewis use of |
@yog27ray i know but this is a foundational PR. Feel free to change it after we merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the type files need to be manually generated calling npm run build:types
and then be committed as part of a PR? Would it be better to generate the type files as part of the release workflow and commit them? Or build the types in the CI and make sure there's no difference to the committed type files, to ensure types are always committed correctly, like with the options definitions.
Signed-off-by: Manuel <[email protected]>
Signed-off-by: Manuel <[email protected]>
# [8.2.0-alpha.1](8.1.1-alpha.1...8.2.0-alpha.1) (2025-04-15) ### Features * Add TypeScript definitions ([#9693](#9693)) ([e86718f](e86718f))
🎉 This change has been released in version 8.2.0-alpha.1 |
Pull Request
Issue
Generated types currently break typescript projects
Closes: #9672
Approach
Ensure index.js, ParseServer.js and LiveQuery/ParseLiveQueryServer.js are typed.