Skip to content

feat: Add TypeScript definitions #9693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 15, 2025
Merged

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Apr 2, 2025

Pull Request

Issue

Generated types currently break typescript projects

Closes: #9672

Approach

Ensure index.js, ParseServer.js and LiveQuery/ParseLiveQueryServer.js are typed.

Copy link

parse-github-assistant bot commented Apr 2, 2025

🚀 Thanks for opening this pull request!

@dplewis dplewis requested a review from a team April 2, 2025 19:21
@dplewis dplewis mentioned this pull request Apr 2, 2025
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.01%. Comparing base (39ef22d) to head (236b417).
Report is 2 commits behind head on alpha.

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #9693      +/-   ##
==========================================
- Coverage   93.16%   93.01%   -0.15%     
==========================================
  Files         187      187              
  Lines       15068    15081      +13     
  Branches        0      174     +174     
==========================================
- Hits        14038    14028      -10     
- Misses       1030     1041      +11     
- Partials        0       12      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yog27ray
Copy link
Contributor

yog27ray commented Apr 5, 2025

@dplewis use of any as a type should be avoided.

@dplewis
Copy link
Member Author

dplewis commented Apr 5, 2025

@yog27ray i know but this is a foundational PR. Feel free to change it after we merge

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the type files need to be manually generated calling npm run build:types and then be committed as part of a PR? Would it be better to generate the type files as part of the release workflow and commit them? Or build the types in the CI and make sure there's no difference to the committed type files, to ensure types are always committed correctly, like with the options definitions.

@mtrezza mtrezza changed the title feat: Add initial Typescript definitions feat: Add initial TypeScript definitions Apr 7, 2025
@mtrezza mtrezza changed the title feat: Add initial TypeScript definitions feat: Add TypeScript definitions Apr 7, 2025
@dplewis dplewis requested a review from mtrezza April 14, 2025 04:55
@mtrezza mtrezza merged commit e86718f into parse-community:alpha Apr 15, 2025
23 of 24 checks passed
parseplatformorg pushed a commit that referenced this pull request Apr 15, 2025
# [8.2.0-alpha.1](8.1.1-alpha.1...8.2.0-alpha.1) (2025-04-15)

### Features

* Add TypeScript definitions ([#9693](#9693)) ([e86718f](e86718f))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 8.2.0-alpha.1

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released-alpha Released as alpha version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

types.ts is empty?
4 participants