Skip to content

Pytest fixes #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 30, 2018
Merged

Pytest fixes #9

merged 4 commits into from
Oct 30, 2018

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Oct 29, 2018

No description provided.

@blueyed
Copy link
Contributor Author

blueyed commented Oct 29, 2018

I am looking into integrating coverage again, let's wait for this to be rebased on that then to ensure nothing is missed.

Copy link
Collaborator

@cdent cdent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks generally good. I agree that waiting on the coverage changes (which I'll look at in a sec) is a good idea.

Fixes

> "cannot collect test class %r because it has a __init__ constructor

Ref: pytest-dev/pytest#2007
This is faster with test collection.
Fixes

> /usr/lib/python3.7/site-packages/_pytest/python.py:764:
> RemovedInPytest4Warning: usage of Generator.Function is deprecated,
> please use pytest.Function instead
@codecov-io
Copy link

codecov-io commented Oct 30, 2018

Codecov Report

Merging #9 into master will decrease coverage by 0.01%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
- Coverage   52.94%   52.92%   -0.02%     
==========================================
  Files         125      125              
  Lines       14746    14741       -5     
  Branches     2502     2500       -2     
==========================================
- Hits         7807     7802       -5     
- Misses       6399     6400       +1     
+ Partials      540      539       -1
Flag Coverage Δ
#py27 51.84% <91.66%> (-0.02%) ⬇️
#py35 51.22% <91.66%> (-0.02%) ⬇️
#py36 51.22% <91.66%> (-0.02%) ⬇️
#py37 51.21% <91.66%> (-0.02%) ⬇️
#pypy 51.08% <91.66%> (-0.04%) ⬇️
Impacted Files Coverage Δ
tests/test_auth/test_auth_digest.py 54.09% <0%> (ø) ⬆️
tests/test_doctests.py 69.23% <100%> (-4.97%) ⬇️
paste/fixture.py 38.83% <100%> (ø) ⬆️
paste/progress.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 495ff97...5f55800. Read the comment docs.

@blueyed
Copy link
Contributor Author

blueyed commented Oct 30, 2018

Should be good it seems.
Pushed some more minor changes.

@cdent cdent merged commit 455203d into pasteorg:master Oct 30, 2018
@blueyed blueyed deleted the pytest branch October 30, 2018 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants