Skip to content

Notification drawer accordion does not work consistently #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
benjaminapetersen opened this issue Aug 3, 2017 · 1 comment
Closed

Notification drawer accordion does not work consistently #545

benjaminapetersen opened this issue Aug 3, 2017 · 1 comment

Comments

@benjaminapetersen
Copy link
Member

Was talking with @jeff-phillips-18 about some issues, he noted height calculation.

I've been experiencing issues where items are truncated. For example, I have 15 items in this list, but only 7 are visible & it will not scroll consistently:

screen shot 2017-08-03 at 12 21 19 am
@benjaminapetersen
Copy link
Member Author

Another example, this time the accordion collapsed entirely:

screen shot 2017-08-03 at 12 39 42 am

jeff-phillips-18 added a commit to jeff-phillips-18/angular-patternfly that referenced this issue Aug 3, 2017
@jeff-phillips-18
Fix notification drawer accordion panel sizing
c32c32a 
Update sizes when elements in the notification drawer are updated.
Update collapse children to not have a intermediate parent.
Fix for example notification drawer body html indentation error.

Fixes patternfly#545
@jeff-phillips-18 jeff-phillips-18 mentioned this issue Aug 3, 2017
Merged
jeff-phillips-18 added a commit to jeff-phillips-18/angular-patternfly that referenced this issue Aug 3, 2017
@jeff-phillips-18
Fix notification drawer accordion panel sizing
7646c4e 
Update sizes when elements in the notification drawer are updated.
Update collapse children to not have a intermediate parent.
Fix for example notification drawer body html indentation error.

Fixes patternfly#545
cdcabrera pushed a commit that referenced this issue Aug 4, 2017
@jeff-phillips-18 @cdcabrera
Fix notification drawer accordion panel sizing (#548)
b7779a1 
Update sizes when elements in the notification drawer are updated.
Update collapse children to not have a intermediate parent.
Fix for example notification drawer body html indentation error.

Fixes #545
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benjaminapetersen