-
Notifications
You must be signed in to change notification settings - Fork 90
fix(pfTrendsChart): In compact layout, tightened up space #591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@dtaylor113 is there a rawgit link I should checkout? |
src/charts/trends/trends-chart.html
Outdated
@@ -19,7 +19,7 @@ | |||
</div> | |||
<div ng-switch-when="compact" class="trend-card-compact-pf"> | |||
<div class="row trend-row"> | |||
<div class="col-sm-4 col-md-4"> | |||
<div class="col-sm-2 col-md-2"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now would be a good time to lose the useless col-md values on these columns since they are the same as the col-sm value. Would clean it up and one less selector in the less file above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, fixed
73cdaf6
to
787613d
Compare
|
src/charts/trends/trends-chart.html
Outdated
@@ -19,7 +19,7 @@ | |||
</div> | |||
<div ng-switch-when="compact" class="trend-card-compact-pf"> | |||
<div class="row trend-row"> | |||
<div class="col-sm-4 col-md-4"> | |||
<div class="col-md-2"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you wanted col-sm-2 here so that at small resolutions these stay on a single line. Only at xs should they be vertical. This goes for all the changes here.
src/charts/charts.less
Outdated
.col-sm-10, .col-md-10 { | ||
padding-left: 0; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should only need the col-sm- selectors now.
787613d
to
c91a731
Compare
Hi @jeff-phillips-18, I (hopefully) fixed the col selectors |
@dtaylor113 The spacing looks good! I'm curious in general, why does the label get stacked on top instead of staying on the right or left at a view like this: |
@dtaylor113 It seems like it should only stack at an xs resolution. @jeff-phillips-18 thought this is how it currently works, but maybe the ngDocs just aren't updated with the latest code? |
@beanh66 The rawgit branch hasn't been updated. I pulled and tested and the latest changes correctly stack only at the xs resolution. |
Description
In compact layout, tightened space up between labels and chart:
PR Checklist
Previous:

Now:

Fixes #579
@serenamarie125