Skip to content

Misc docs - demos should not use randomly generated data #11768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kmcfaul opened this issue Apr 17, 2025 · 1 comment · May be fixed by #11769
Open

Misc docs - demos should not use randomly generated data #11768

kmcfaul opened this issue Apr 17, 2025 · 1 comment · May be fixed by #11769
Assignees
@Mash707
Labels
PF Team

Comments

@kmcfaul
Copy link
Contributor

kmcfaul commented Apr 17, 2025 •
edited
Loading

Data for the following demos should be updated to be static to prevent false positives from screenshot diff testing / backstop runs.

  • /components/data-list/react-demos/static-bottom-pagination
  • /components/table/react-demos/bulk-select
  • /components/table/react-demos/column-management
  • /components/table/react-demos/column-management-with-draggable
  • /components/table/react-demos/compact
  • /components/table/react-demos/filterable
  • /components/table/react-demos/sort
  • /components/table/react-demos/sticky-header
  • /patterns/right-to-left/react-demos/paginated-table
  • /components/timestamp/react/default-tooltip

Data can either be statically defined per demo, or just set specific numbers/label states instead of using random
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Apr 17, 2025
@kmcfaul kmcfaul moved this from Needs triage to Backlog in PatternFly Issues Apr 17, 2025
@Mash707
Copy link
Contributor

Mash707 commented Apr 17, 2025

Hi @kmcfaul I would like to work on this. We can have data statically defined similar to charts.

@Mash707 Mash707 linked a pull request Apr 20, 2025 that will close this issue
Open
@kmcfaul kmcfaul moved this from Backlog to PR Review in PatternFly Issues Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mash707 Mash707

Labels
PF Team
Projects
PatternFly Issues
Status: PR Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(docs): use static values in demos Mash707/patternfly-react
2 participants
@kmcfaul @Mash707