Skip to content

chore(docs): use static values in demos #11769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore(docs): use static values in demos #11769

wants to merge 2 commits into from
+586 −590

Conversation

Mash707
Copy link
Contributor

@Mash707 Mash707 commented Apr 20, 2025

Closes #11768

@patternfly-build
Copy link
Contributor

patternfly-build commented Apr 20, 2025 •
edited
Loading

Preview: https://patternfly-react-pr-11769.surge.sh

A11y report: https://patternfly-react-pr-11769-a11y.surge.sh

@Mash707
Copy link
Contributor Author

Mash707 commented Apr 20, 2025

/patterns/right-to-left/react-demos/paginated-table should I create a sampleData.tsx for this similar to other demos?

thatblindgeye
thatblindgeye requested changes Apr 21, 2025
View reviewed changes
Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make a similar update to the TimestampBasicFormats example file

@thatblindgeye
Copy link
Contributor

@Mash707 for now we could just update those random values in the PaginatedTable file itself

@Mash707
Copy link
Contributor Author

Mash707 commented Apr 21, 2025

@Mash707 for now we could just update those random values in the PaginatedTable file itself

@thatblindgeye There are 25 entries for this example https://www.patternfly.org/patterns/right-to-left/react-demos/paginated-table/, this would make the source code pretty big with unnecessary information. Let me know what you think

@Mash707 Mash707 force-pushed the docs-use-static-data-demos branch from 45b61dd to a511304 Compare April 21, 2025 18:10
@thatblindgeye
Copy link
Contributor

@Mash707 Ah yeah fair, may not hurt to have a separate file for that data then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatblindgeye thatblindgeye thatblindgeye requested changes

@nicolethoen nicolethoen nicolethoen approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Misc docs - demos should not use randomly generated data
4 participants
@Mash707 @patternfly-build @thatblindgeye @nicolethoen