Create KMP settings screen #331
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhosNickDoglio
changed the title
WhosNickDoglio
force-pushed
the
ndoglio/settings-kmp
branch
from
ae1844f to
0f36da5
Compare
WhosNickDoglio
force-pushed
the
ndoglio/settings-kmp
branch
2 times, most recently
from
665c896 to
0c962d0
Compare
|
Should this target master or kmp? Looking at both it looks like most KMP code is already in master 😅 |
WhosNickDoglio
changed the title
hellcp
reviewed
Mar 23, 2025
android/shared/src/commonMain/kotlin/io/rebble/cobble/shared/ui/view/home/settings/Settings.kt
Outdated
Show resolved
Hide resolved
android/shared/src/commonMain/kotlin/io/rebble/cobble/shared/ui/view/home/settings/Settings.kt
Outdated
Show resolved
Hide resolved
hellcp
approved these changes
Mar 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of a couple for #304. This just focused on setting up a placeholder Settings screen, later PRs will add the Account card and make each item navigable. Trying to get this in while I work on the Account card which I think will be a little more complicated 😅
Figma