Skip to content

Direct users to auth to reset app boot config #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

Direct users to auth to reset app boot config #51

wants to merge 11 commits into from

Conversation

bmacphail
Copy link
Contributor

@bmacphail bmacphail commented Apr 17, 2019 •
edited
Loading

The purpose of this PR is now just for the two changes that direct users to go to auth.rebble.io to reset their Pebble app config. For just all the other changes, see #52.

@ja-besse ja-besse mentioned this pull request Apr 17, 2019
Merged
@ja-besse
Copy link
Contributor

In the howto, there is a mention of the "unrebble" URI (under I want to add an original Pebble or Pebble Steel, but the firmware upgrade step displays "Migration Failed"). Maybe add a link to unrebble.html there?

@bmacphail
Delete unrebble.html
5408973 
A better solution now exists in the form of a default app config link on the user's subscription page (see my other pull request)
@bmacphail
Copy link
Contributor Author

bmacphail commented Apr 17, 2019 •
edited
Loading

Good idea. I have taken the liberty of making unrebble.html obsolete by submitting another pull request to include the URI in the auth/account page. I'll add info on that to the howto.

@ishotjr ishotjr self-requested a review April 21, 2019 04:41
@ishotjr ishotjr self-assigned this Apr 21, 2019
@ishotjr
Copy link
Member

ishotjr commented Apr 21, 2019

@MisterSpak this is great! Would it be possible to break it into two PRs, one covering just the dependency on pebble-dev/rebble-auth-py#7 (i.e. since that may take some time to put into production) and the other covering the rest? 😍 👍

@bmacphail bmacphail mentioned this pull request Apr 21, 2019
Merged
@bmacphail bmacphail changed the title Updated old pages to acknowledge the existence of RPWS and Rebble's current status, also updated howto to point Android users to APKMirror for the app download Direct users to auth to reset app boot config Apr 21, 2019
@bmacphail
Copy link
Contributor Author

bmacphail commented Apr 21, 2019 •
edited
Loading

@MisterSpak this is great! Would it be possible to break it into two PRs, one covering just the dependency on pebble-dev/rebble-auth-py#7 (i.e. since that may take some time to put into production) and the other covering the rest? 😍 👍

@ishotjr Done! I've created a new PR (#52) just for the changes that don't rely on updating auth and edited the title of this PR.

@ishotjr
Copy link
Member

ishotjr commented Apr 23, 2019

@MisterSpak I had some feedback that I'd love to incorporate into this (or another) PR when poss.... ❤️

@bmacphail
Copy link
Contributor Author

I kinda screwed up my master branch here so I'm just gonna close this.

@bmacphail bmacphail closed this Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishotjr ishotjr Awaiting requested review from ishotjr

Assignees

@ishotjr ishotjr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bmacphail @ja-besse @ishotjr