PMM-11984: Add new metrics pg_available_extensions and pg_extensions to expose info about available extensions and installed extensions accordingly
#117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns` to expose info about available extensions and installed extensions accordingly
|
|
0leksii
approved these changes
May 1, 2023
ritbl
reviewed
May 8, 2023
ritbl
reviewed
May 8, 2023
| "Extensions that are available for installation", | ||
| []string{ | ||
| "name", | ||
| "default_version", |
There was a problem hiding this comment.
what does it mean default? used? I think we need a better name here
There was a problem hiding this comment.
these lablels are copies of column names from the table from which we fetch these metrics.
I believe it means if you install this extensions and not specify the version this default version will be used.
ritbl
reviewed
May 8, 2023
collector/pg_extensions.go
Outdated
| "pg_extensions", | ||
| "Installed extensions", | ||
| []string{ | ||
| "extname", |
There was a problem hiding this comment.
probably it means 'extension'
removed it
ritbl
reviewed
May 8, 2023
ritbl
reviewed
May 8, 2023
ritbl
reviewed
May 8, 2023
collector/pg_extensions.go
Outdated
| ch <- prometheus.MustNewConstMetric( | ||
| pgExtensions["pg_extensions"], | ||
| prometheus.GaugeValue, 1, | ||
| extname, strconv.FormatBool(extrelocatable), extversion, |
There was a problem hiding this comment.
how about putting each param on it's own line?
ritbl
reviewed
May 8, 2023
ritbl
reviewed
May 8, 2023
| ), | ||
| } | ||
|
|
||
| type ExtensionsCollector struct { |
There was a problem hiding this comment.
how about checking that struct implements interface?
…nsions-metrics' into PMM-11984-add-collector-for-extensions-metrics
ritbl
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FB: Percona-Lab/pmm-submodules#3258