Skip to content

Gitlab domain name changed to httpslab #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
uipo78 opened this issue Jan 10, 2019 · 4 comments · Fixed by #52
Closed

Gitlab domain name changed to httpslab #48

uipo78 opened this issue Jan 10, 2019 · 4 comments · Fixed by #52

Comments

@uipo78
Copy link

uipo78 commented Jan 10, 2019

pretty sure the fix is to add something like this a line or two hereunder:

url="${url/httpslab/gitlab}"

lemme know if you'd like me to submit a pr :D

@peterhurford
Copy link
Owner

This sounds reasonable. A PR would be grand. Thanks! Do you have any Gitlab repos and would you be able to test?

@alichtman
Copy link
Contributor

I just ran into this same issue. Any idea when this will be fixed?

@peterhurford
Copy link
Owner

I don't intend to fix this myself but I'd happily accept a PR

@alichtman
Copy link
Contributor

alichtman commented Jun 22, 2020

No worries. I’ll fix it next time it really annoys me (and I somehow manage to clear my never ending todo list)

Btw thanks for this little tool. I use it all the time in my development flow

alichtman added a commit to alichtman/git-it-on.zsh that referenced this issue Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants