-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failed to execute 'setTransform' on 'CanvasRenderingContext2D': 6 arguments required, but only 1 present. #6965
Comments
Hiya - how old is this device/set-up you're testing? Because |
yeees, that is pretty old browser, from 2017 probably. Full situation: Of course we wish that everybody use the newest version of SketchUp, but reality is not like that :P in worst scenario I will just update the source code each time :P |
If you want to submit a PR then I don't mind reverting to the old way of doing it for the v3.88 release. This will be one of our final v3.x releases and we won't maintain this going forward for 4.x, but I don't mind doing it here. |
add backward compatibility for setTransform function #6965
Thanks for opening this issue, and for submitting a PR to fix it. We have merged your PR into the |
Version
Description
When open that browser I have an error:
Uncaught TypeError: Failed to execute 'setTransform' on 'CanvasRenderingContext2D': 6 arguments required, but only 1 present.
this problem do not invoke in newest version of Sketchup Browser (like CEF 88 and above)
Example Test Code
in the config file I am using Phaser.CANVAS, because that renderer is better for my case (using phaser to visualize pdf so thin lines are necessary)
when Phaser.Auto then it is working but that renderer isn't good in my case
Additional Information
I have solved that issue by changing line
return t.setTransform(this),t}
into
return t.setTransform(this.a, this.b, this.c, this.d, this.e, this.f),t}
not sure if it is safe solution, but it's working ;P
maybe in future releases you can add something like this.
ps. very very great library!!!
The text was updated successfully, but these errors were encountered: