Update ArcadeColliderType.js #7095
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
note in the diff also some of the individual types were not carried over to the array types prior to this change, i believe that is also incorrect. the array type is now simply an array that can have any of the preceding types of ArcadeColliderType as a member... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Describe the changes below:
ArcadeColliderTypetypedef/jsdoc is mildly incorrect. The array versions of this type do not need to be of a single type (see collider code here for example) but rather if it's an array that array can be a mix of any of the various single types, as https://github.com/phaserjs/phaser/blob/master/src/physics/arcade/World.js#L1934 is going to test each member of the array anyway. Note, this still works if you pass an array of a single type, it just doesn't force you to do that, as it isn't actually necessary.