Check whether json2ts exited without any errors before processing the generated ts file #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…new file due to whatever reason 'remove_master_model_from_output' is still called, this results in a confusing error message. Instead check exit code of json2ts and output it to log.
phillipdupuis
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
json2ts started failing on my machine due to some hard to reproduce issue related running x86 binaries on an m1 mac. However since the output file was still there (it previously worked fine) pydantic-to-typescript still attempted to call 'remove_master_model_from_output' on it and failed with this message as a result:
line 111, in remove_master_model_from_output
new_lines = lines[:start] + lines[(end + 1) :]
TypeError: unsupported operand type(s) for +: ‘NoneType’ and ‘int’
(the error is the same as in #5, not sure if it's caused by the same issue)
because obviously the master model was already stripped. This was confusing and it took me some time to figure out that json2ts was failling.