Remove root logger configuration #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarkAce65
commented
Apr 18, 2021
| @@ -223,6 +221,8 @@ def main(module: str, output: str, json2ts_cmd: str = "json2ts") -> None: | |||
| """ | |||
| CLI entrypoint to run :func:`generate_typescript_defs` | |||
| """ | |||
| logging.basicConfig(level=logging.DEBUG, format="%(asctime)s %(message)s") | |||
There was a problem hiding this comment.
Moving this here makes it so calling pydantic2ts will still print debug logs but importing generate_typescript_defs won't print by default
There was a problem hiding this comment.
Thank you! Doing the work for me AND teaching me something very useful/relevant, I can't ask for more than that 😛
But I do really appreciate it, and your solution makes sense -- merging this in now and then I'll release it along with a few other minor changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just found this library and started implementing it in an app I'm building - thanks for writing this! One thing I ran into was that the library sets a configuration for the root logger to log at the debug level and propagates to all other loggers. This resulted in other imported libraries also logging at the debug level (which I didn't want).
I found this section in the official documentation that recommends against calling
logging.basicConfigin libraries and letting the application configure logging. (Which I found from this SO answer).Let me know what you think!