Skip to content

fix #1 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2016
Merged

fix #1 #3

merged 1 commit into from
Jan 7, 2016

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Jan 7, 2016

Since Flysystem removes "any kind of funky unicode whitespace" we might run into a situation like this:

// Empty cache
$item = $pool->getItem('foo[funky unicode]bar");
$item->set('value');
$pool->save($item);

$pool->hasItem('foobar"); // True

This PR prevents that situation.

This will fix #1

@codecov-io
Copy link

Current coverage is 100.00%

Merging #3 into master will not affect coverage as of 881a6dc

@@            master      #3   diff @@
======================================
  Files            1       1       
  Stmts           25      27     +2
  Branches         0       0       
  Methods          6       6       
======================================
+ Hit             25      27     +2
  Partial          0       0       
  Missed           0       0       

Review entire Coverage Diff as of 881a6dc

Powered by Codecov. Updated on successful CI builds.

Nyholm added a commit that referenced this pull request Jan 7, 2016
@Nyholm Nyholm merged commit 1985f7a into php-cache:master Jan 7, 2016
@Nyholm Nyholm deleted the patch-1 branch January 7, 2016 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants