Skip to content

Incorrect number of stamps by countries and categories when collection contains incomplete series #1143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
php-coder opened this issue Oct 23, 2019 · 4 comments
Closed

Incorrect number of stamps by countries and categories when collection contains incomplete series #1143

php-coder opened this issue Oct 23, 2019 · 4 comments
Assignees
@php-coder
Labels
kind/bug
Milestone
0.4.2

Comments

@php-coder
Copy link
Owner

php-coder commented Oct 23, 2019 •
edited
Loading

Steps to reproduce:

  • add a series id=2 to user's collection with only 1 stamp
  • on the collection page, check statistics by categories/countries

Expected result: 1 stamp
Actual result: 2 stamps
@php-coder php-coder added this to the 0.4.2 milestone Oct 23, 2019
@php-coder php-coder self-assigned this Nov 2, 2019
@php-coder
Copy link
Owner Author

This is hard or nearly impossible to test as this statistic affects only diagrams. I'm going to write tests for DAO layer to ensure that the methods returns different numbers depending on data.

php-coder added a commit that referenced this issue Nov 4, 2019
@php-coder
refactor(CategoryService.getStatisticsOf): change return value to Map.
9137e6f 
Prerequisite for #1143
php-coder added a commit that referenced this issue Nov 5, 2019
@php-coder
refactor(CountryService.getStatisticsOf): change return value to Map.
b3f64d2 
Prerequisite for #1143
php-coder added a commit that referenced this issue Nov 8, 2019
@php-coder
test(JdbcCategoryDaoTest): add tests for getStatisticsOf() method.
7de0591 
Prerequisite for #1143
This was referenced Nov 8, 2019
Closed
Closed
@0pdd
Copy link

0pdd commented Nov 8, 2019

@php-coder 2 puzzles #1150, #1151 are still not solved.

php-coder added a commit that referenced this issue Nov 8, 2019
@php-coder
fix: a diagram on collection page shows incorrect number of stamps by…
c5441da 
… categories when a user has an incomplete series.

Fix half of #1143
php-coder added a commit that referenced this issue Nov 9, 2019
@php-coder
test(JdbcCountryDaoTest): add tests for getStatisticsOf() method.
9683990 
Prerequisite for #1143
php-coder added a commit that referenced this issue Nov 9, 2019
@php-coder
fix: a diagram on collection page shows incorrect number of stamps by…
7c2c361 
… countries when a user has an incomplete series.

Fix the last half of #1143
@php-coder
Copy link
Owner Author

php-coder commented Nov 9, 2019 •
edited
Loading

Done -- both counters have been fixed.

@php-coder php-coder mentioned this issue Nov 9, 2019
Closed
@0pdd
Copy link

0pdd commented Dec 12, 2019

@php-coder the puzzle #1151 is still not solved; solved: #1150.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
kind/bug
Projects
None yet
Milestone
0.4.2
Development

No branches or pull requests
2 participants
@php-coder @0pdd